[DependencyInjection] [Service Container] Fix Service parameters typo in services.yml #14682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Yondz. This indeed looks quite weird. What do you think about modifying the example a little bit, like this: If you agree, please update your PR (by pushing to |
|
Hi @wouterj , That's okay and better :) I might have to update the I'll update this :) |
Yondz
changed the title
|
Oh ah, yeah it's a bit confusing in XML/PHP, as the |
|
And furthermore, when you scroll down a bit, there's even a redundancy with this example : # config/services.yaml
services:
# ... same code as before
# explicitly configure the service
App\Service\MessageGenerator:
arguments:
# the '@' symbol is important: that's what tells the container
# you want to pass the *service* whose id is 'monolog.logger.request',
# and not just the *string* 'monolog.logger.request'
$logger: '@monolog.logger.request'Maybe this would be a good tradeoff : services:
App\Service\MessageGenerator:
arguments:
# this is not a string, but a reference to a service called 'logger'
- '@logger'
# if the value of a string argument starts with '@', you need to escape
# it by adding another '@' so Symfony doesn't consider it a service
# the following example would be parsed as the string '@securepassword' :
# - '@@securepassword'WDYT ? |
Yondz
force-pushed
the
fix_service_container_service_parameters
branch
2 times, most recently
from
4d90253 to
e5e2122
Compare
Yondz
force-pushed
the
fix_service_container_service_parameters
branch
from
e5e2122 to
a741c9c
Compare
Yondz
changed the title
javiereguiluz
added
Status: Reviewed
DependencyInjection
and removed
Status: Needs Review
labels
carsonbot
changed the title
|
Greg, it took us some time, but this is finally merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed a strange yml in the service_container doc, affecting >= 4.3 , there was a misplaced parameter under an example service definition.
I thought it would be nice to keep the actual information about escaping using
@so I just removed the wrongmailer_password: '@@securepassword'thing.I used 4.4 as target, maybe this could be merged to 4.3 as well, I'll let you check this point !
=)